Search Forums
Forums
Kiwitrees on Twitter
    Tags

    Support/Bug Reporting, logout, 2.0.2, 3.2.1, 3.3.0, blocks, gettext, menu, simpl_pages, access level, tags, upgrade, 3.1.1, session, reports, theme, emmigration, media_links, MAC, bug reporting, spouse, album, order, Relationship, white screen, colors theme, colors, block, GEDCOM errors, ASSO, Google Maps, .po, bug, 2.0, family, menus, translate, roadmap, type, FAQ, research, language, future, google, notes, xmas, calendar, events of close relatives, flags, IE problem, privacy, Favourites, footer, fatal error, responsive menus, lists, json, data errors, add_asso_facts, CHR

    Tagged: 

    Topic:   Sanity Request – media  

    This topic contains 10 replies, has 2 voices, and was last updated by kiwi kiwi 3 weeks, 6 days ago.

    Viewing 11 posts - 1 through 11 (of 11 total)
    • Author
      Posts
    • #8815

      jacoline
      Participant

      410 posts

      1) Searching for a server file with more than 1 Mxxx number (by mass upload it happens sometimes to create 2 Mxxx numbers linked to only one file)

      2) Searching for Media with no links

      Regards,
      Jamie Jaconelli

      admin and owner of:
      www.jaconelli.dk/webtrees, www.host-siden.dk/history, www.familien-johnsen.dk and danish support at www.host-siden.dk/sandbox

      #8837
      kiwi
      kiwi
      Keymaster

      1447 posts

      Interesting. I hadn’t thought there would be checks related to media.

      However, no 2. does already exist. Some time ago (can’t remember exactly how long) I changed the tool Administration > Family tree tools > Find unlinked individuals to Administration > Family tree tools > Find unlinked records. So that tool now lists unlinked individuals, sources, notes, repositories, and media.

      For number 1., would you assume that any such duplicates would link to media files in the same folder or sub-folder? Or could they be in different sub-folders?

      I think the check would have to assume they are in the same folder. Otherwise it would be entirely possible that, for example, /portraits/john_smith.jpg might be a completely different image to /people/john_smith.jpg.

      I’m also unclear about how these duplicates happen. It’s not like births deaths etc where duplication is quite easy. Kiwitrees is coded to only use any XREF (like M12345) once per family tree. When it creates a new OBJE it will not use an existing Mxxx.
      I need to be able to create the problem so that I can test the code that finds it 🙂 Do you have a GEDCOM that includes the problem?

      Nigel

      My personal kiwitrees site is www.our-families.info

      #8840

      jacoline
      Participant

      410 posts

      In my case it would be in same folder (agree would be to complicated otherwise).

      I think it is only important for users with alot of media (like me). Less than a 1000 is not a problem to look after this. If the server says 945 files and the medialist says 946 files then there prolly is a file with 2 Mxx numbers. Except if the system also contains external media. But as I know they do not show in medialist for local files 🙂

      1) You can have a media file at server called “giraf.jpg”. This media file can have more than 1 Mxxx number ex: M204 and M1415. This happend to me by media uploaded by ftp and using the “unused media” where I created the Mxxx number. If new users have alot of media with no links they would the Mxxx numbers like this. If you by accident click at the same “giraf.jpg” more than 1 time you add more Mxxx numbers.

      Imagine you have 100 files. You see them in unused! The selector is 10 (to view). You click at the 10 and just make close at the window (where you do not update the “unused medialist”) then it happens you can do this! If you have many you want to spare the time for the “update”.

      2) Oh I did not see there! Was not logic to me to look after this in that area after you made the sanity request. Thank you 🙂

      P.S. You can see it by me cause I still have 1 more Mxxx number than files in that server folder.

      Regards,
      Jamie Jaconelli

      admin and owner of:
      www.jaconelli.dk/webtrees, www.host-siden.dk/history, www.familien-johnsen.dk and danish support at www.host-siden.dk/sandbox

      #8841
      kiwi
      kiwi
      Keymaster

      1447 posts

      This happend to me by media uploaded by ftp and using the “unused media” where I created the Mxxx number.

      That is the part I do not understand. You cannot manually create a Mxxx number.
      If a file already has an Mxxx number, then it can not be in the “unused” file list, unless either:

      1. the file name is different (even one character is “different”), or
      2. the file is in a different folder, or
      3. you are “creating” the Mxxx in a different family tree.

      None of these will appear as a duplicate.

      If you FTP a new version of an existing file, it does not create a new one. It just replaces it.

      I suspect that your assumption “ If the server says 945 files and the medialist says 946 files then there prolly is a file with 2 Mxx numbers.” is not correct. There might be another reason.

      What I will do (try) is to create a temporary check tool for you that finds the one Mxxx number that is not on the server. Does this situation exist on your 7.1 test server where I can look at both the software and the server files?

      That way either we will solve your particular issue (and not need a tool) or I will be wrong and I can use it to create a tool for everyone.

      Nigel

      My personal kiwitrees site is www.our-families.info

      #8842

      jacoline
      Participant

      410 posts

      I had 6 of them where I found 5 and edit those. The 6th I did not look for bc of this thread. No but I can make one at the test server. I can try to make images how this happens!

      The file will always be at the server. The file just have 2 different M-numbers.

      Server: (1 files)
      giraf.jpg

      Medialist: (2 items)
      M204 (giraf.jpg)
      M1415 (giraf.jpg)

      Regards,
      Jamie Jaconelli

      admin and owner of:
      www.jaconelli.dk/webtrees, www.host-siden.dk/history, www.familien-johnsen.dk and danish support at www.host-siden.dk/sandbox

      #8843

      jacoline
      Participant

      410 posts

      Imagine this happens if alot of files in the “unused” I hope you can see it. The result is still there at my test (7.1)

      I hope you can use the enclosed (otherwise Ill email you the images)

      Regards,
      Jamie Jaconelli

      admin and owner of:
      www.jaconelli.dk/webtrees, www.host-siden.dk/history, www.familien-johnsen.dk and danish support at www.host-siden.dk/sandbox

      Attachments:
      You must be logged in to view attached files.
      #8845
      kiwi
      kiwi
      Keymaster

      1447 posts

      Yes I can see the pdf file. I’ll look at the test site probably tomorrow.

      Nigel

      My personal kiwitrees site is www.our-families.info

      1 user thanked author for this post.
      #8846

      jacoline
      Participant

      410 posts

      No rush 🙂

      Just remember it only happens if accidently clicking at the same file twice (or more). Does not matter if you hit close button or not! I just tried to specify how this can be done after hitting the “creating” and both are open in separated windows (with perhabs 10 others).

      I think it will be to complicated to lookup for allready made Mxx number at same file in the adding process. It will prolly also slow down the media adding process. But a sanity can help.

      Something about counting server files with the m-files in the folder. Then after look for which files having more than 1 Mxxx number. Result (click for edit)
      Or something like that – better than slowing down the adding process 🙂

      Regards,
      Jamie Jaconelli

      admin and owner of:
      www.jaconelli.dk/webtrees, www.host-siden.dk/history, www.familien-johnsen.dk and danish support at www.host-siden.dk/sandbox

      #8847
      kiwi
      kiwi
      Keymaster

      1447 posts

      I think it will be to complicated to lookup for allready made Mxx number at same file in the adding process. It will prolly also slow down the media adding process.

      No, not complicated and can not slow anything down, because it is already part of the code, and has been for ever. This is why I do not understand (yet) how it can happen.

      Hopefully tomorrow I will know better. If it can happen it is a bug which must be fixed. The system is designed for multiple users editing at the same time. This is more important (to me) than any check after the damage is done.

      Nigel

      My personal kiwitrees site is www.our-families.info

      1 user thanked author for this post.
      #8848

      jacoline
      Participant

      410 posts

      ah I see your point. I Did not think about it in that way! 🙂

      Regards,
      Jamie Jaconelli

      admin and owner of:
      www.jaconelli.dk/webtrees, www.host-siden.dk/history, www.familien-johnsen.dk and danish support at www.host-siden.dk/sandbox

      #8849
      kiwi
      kiwi
      Keymaster

      1447 posts

      OK, problem found. The clue was your comment above, which said:

      Does not matter if you hit close button or not!

      Also this from your PDF of the process:
      creating-mediafiles_004

      There are in fact two problems:

      1. You MUST always use that close button. The system breaks (as you found) if you do not. That is the way that code is (and always has been) designed, and I do not want to change it at this time.
      2. The main problem was that the close button was not working properly. When you click “close” it should close that tab and refresh the original one (the list of unused media) That is why it did not help if you clicked the close button or not.

      I have added a temporary fix for this on your test site. The “close” now works as designed, and the button has a reminder that you MUST use it.

      I hope before the next release I can amend the code so the close button is not required. It’s the only page left over from PGV that still has it, but so far getting rid of it is proving problematic.

      If you want to use the same fix for your live site just copy these two files from your test site:
      kiwitrees/addmedia.php
      kiwitrees/admin_media.php

      I did also read your early comment

      Imagine you have 100 files. You see them in unused! The selector is 10 (to view). You click at the 10 and just make close at the window (where you do not update the “unused medialist”) then it happens you can do this! If you have many you want to spare the time for the “update”.

      I understand it can sometimes be slow to refresh the unused list if there are many items. But there is no easy way to avoid this. Like all other edit screens, you have to do one edit, then refresh the screen.

      Nigel

      My personal kiwitrees site is www.our-families.info

      Attachments:
      You must be logged in to view attached files.
    Viewing 11 posts - 1 through 11 (of 11 total)

    You must be logged in to reply to this topic.